Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply a dummy default controller config #215

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

bavarianbidi
Copy link
Member

to make garm work after the initialization, we apply a default config for webhookURL, metadataURL and callbackURL

this config will be overwritten once a garmserverconfig CR got applied

during the initial start of garm with the operator, the controller info will look like:

+-------------------------+-------------------------------------------------------------------------+
| FIELD                   | VALUE                                                                   |
+-------------------------+-------------------------------------------------------------------------+
| Controller ID           | dd2524b9-0789-499d-ba7d-3dba65cf9d3f                                    |
| Hostname                | garm-server-7c9d8f57b6-54zt2                                            |
| Metadata URL            | https://initial.metadata.garm.cloud                                     |
| Callback URL            | https://initial.callback.garm.cloud                                     |
| Webhook Base URL        | https://initial.webhook.garm.cloud                                      |
| Controller Webhook URL  | https://initial.webhook.garm.cloud/dd2524b9-0789-499d-ba7d-3dba65cf9d3f |
| Minimum Job Age Backoff | 30                                                                      |
| Version                 | v0.1.5                                                                  |
+-------------------------+-------------------------------------------------------------------------+

after a corresponding garmserverconfig CR gets applied, the controller info will look like:

garm-cli-v0.1.5 controller show
+-------------------------+---------------------------------------------------------------------------------------------+
| FIELD                   | VALUE                                                                                       |
+-------------------------+---------------------------------------------------------------------------------------------+
| Controller ID           | dd2524b9-0789-499d-ba7d-3dba65cf9d3f                                                        |
| Hostname                | garm-server-7c9d8f57b6-54zt2                                                                |
| Metadata URL            | http://garm-server.garm-server.svc:9997/api/v1/metadata                                     |
| Callback URL            | http://garm-server.garm-server.svc:9997/api/v1/callbacks                                    |
| Webhook Base URL        | http://garm-server.garm-server.svc:9997/api/v1/webhook                                      |
| Controller Webhook URL  | http://garm-server.garm-server.svc:9997/api/v1/webhook/dd2524b9-0789-499d-ba7d-3dba65cf9d3f |
| Minimum Job Age Backoff | 30                                                                                          |
| Version                 | v0.1.5                                                                                      |
+-------------------------+---------------------------------------------------------------------------------------------+

to make garm work after the initialization, we apply a default config
for webhookURL, metadataURL and callbackURL

this config will be overwritten once a garmserverconfig CR got applied

Signed-off-by: Mario Constanti <[email protected]>
@bavarianbidi bavarianbidi merged commit 114eda2 into main Nov 20, 2024
3 checks passed
@bavarianbidi bavarianbidi deleted the handle_uninitialized_garm branch November 20, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants