fix: duplicate pools #167
Merged
fix: duplicate pools #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafalgalaw
requested review from
bavarianbidi,
maigl and
H777K
as code owners
bavarianbidi
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug, where two pools crs could reference two differently named image crs with the same image tag specified. Both pools would get the same ID, as garm would only create one pool internally which caused an unexpected behaviour of the whole pool reconciliation logic / spinning of runners.
NOTE:
This should be absolote for garm v0.1.5 as garm allows multiple pools with same image, github-scope, flavor and provider