Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go 1.14 for release build #79

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Conversation

dtan4
Copy link
Member

@dtan4 dtan4 commented Jul 27, 2020

WHAT

Use Go 1.14 to build binaries for release, as well as testing.

WHY

We use Go 1.14 to run tests (ref). However, GoReleaser still uses Go 1.13.

We should use the same Go version through the development/release pipeline.

@dtan4 dtan4 requested a review from babarot as a code owner July 27, 2020 11:12
@dtan4 dtan4 self-assigned this Jul 27, 2020
@dtan4
Copy link
Member Author

dtan4 commented Aug 4, 2020

Thank you for the review!

@dtan4 dtan4 merged commit fb178d8 into master Aug 4, 2020
@dtan4 dtan4 deleted the dtan4/use-go-1.14-for-release branch August 4, 2020 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants