This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
reopen access/error logs on sighup #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cubicdaiya
reviewed
Oct 13, 2016
| } | ||
| } | ||
| } | ||
| }() |
There was a problem hiding this comment.
Looks too deep nest to me.
|
@cubicdaiya refactored signal handler to avoid deep nest. |
kazegusuri
force-pushed
the
log-reopen
branch
from
01d3b3d to
29bb89f
Compare
cubicdaiya
reviewed
Nov 24, 2016
| } | ||
|
|
||
| return zap.New(encoder, level, zap.Output(writer), zap.ErrorOutput(writer)), nil | ||
| writeSyncer := zap.AddSync(writer) |
There was a problem hiding this comment.
Why is zap.AddSync added?
There was a problem hiding this comment.
zap.Output requires zap.WriteSyncer. io.Writer needs to use zap.AddSyncer to implement zap.WriteSyncer.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by using github.com/client9/reopen