This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
enhanced retry mechanism #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gaurun accepts multiple push requests with the two methods below. 1. multiple notifications 2. multiple tokens in single notification When the method of 2 is used and invalid token is included in requested tokens and retry is enabled, there is the potential to push notifications redundantly.
The result is always same.
Because Enqueueing to channel is possible to be blocked when channel is full.
|
LGTM. But there is an impact to users who use |
|
@kazegusuri I see. I'll note that in the next release. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gaurun doesn't retry to push except when server side error is the cause. The result is always same.