Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Commit

Permalink
Merge pull request #54 from mercari/update-dep
Browse files Browse the repository at this point in the history
logger: followed upstream change of uber-go/zap.
  • Loading branch information
kazegusuri authored Nov 22, 2016
2 parents 94f9d35 + d8727dc commit 6911ad4
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 25 deletions.
11 changes: 2 additions & 9 deletions cmd/gaurun/gaurun.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,22 +47,15 @@ func main() {
}

// set logger
accessLogger, err := gaurun.InitLog(gaurun.ConfGaurun.Log.AccessLog)
accessLogger, err := gaurun.InitLog(gaurun.ConfGaurun.Log.AccessLog, "info")
if err != nil {
gaurun.LogSetupFatal(err)
}
errorLogger, err := gaurun.InitLog(gaurun.ConfGaurun.Log.ErrorLog)
errorLogger, err := gaurun.InitLog(gaurun.ConfGaurun.Log.ErrorLog, gaurun.ConfGaurun.Log.Level)
if err != nil {
gaurun.LogSetupFatal(err)
}

if err := gaurun.SetLogLevel(accessLogger, "info"); err != nil {
gaurun.LogSetupFatal(err)
}
if err := gaurun.SetLogLevel(errorLogger, gaurun.ConfGaurun.Log.Level); err != nil {
gaurun.LogSetupFatal(err)
}

gaurun.LogAccess = accessLogger
gaurun.LogError = errorLogger

Expand Down
11 changes: 4 additions & 7 deletions gaurun/log.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ type LogPushEntry struct {
Expiry int `json:"expiry,omitempty"`
}

func InitLog(outString string) (zap.Logger, error) {
func InitLog(outString string, levelString string) (zap.Logger, error) {
var writer zap.WriteSyncer
switch outString {
case "stdout":
Expand All @@ -60,16 +60,13 @@ func InitLog(outString string) (zap.Logger, error) {
return zap.String("time", t.Local().Format("2006/01/02 15:04:05 MST"))
}),
)
return zap.New(encoder, zap.Output(writer), zap.ErrorOutput(writer)), nil
}

func SetLogLevel(log zap.Logger, levelString string) error {
var level zap.Level
if err := level.UnmarshalText([]byte(levelString)); err != nil {
return err
return nil, err
}
log.SetLevel(level)
return nil

return zap.New(encoder, level, zap.Output(writer), zap.ErrorOutput(writer)), nil
}

// LogSetupFatal output error log with log package and exit immediately.
Expand Down
10 changes: 5 additions & 5 deletions glide.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 0 additions & 4 deletions glide.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,6 @@ import:
- payload/badge
- push
- package: github.com/mercari/gcm
version: 987b1dc4ce9034b698395d35de1aadf999388b8f
- package: github.com/fukata/golang-stats-api-handler
version: e7ee1630fdb679c86ec8e3d0755e3576675fdb10
- package: github.com/stretchr/testify
version: v1.1.3
- package: github.com/uber-go/zap
version: f1942381637c11a802c356e70ab5b0a953540bb5

0 comments on commit 6911ad4

Please sign in to comment.