Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Makefile inputs to make build reproducible #168

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Sort Makefile inputs to make build reproducible #168

merged 1 commit into from
Aug 18, 2021

Conversation

davidpolverari
Copy link
Contributor

Some Linux distributions (such as Debian [1]) are striving to make their
build reproducible.

The usage of filesystem globbing as an input to the make build might
cause inconsistencies due to differences between locales [2]. This
inconsistent behavior prevents reproducible builds.

This patch sorts the Makefile inputs to ensure they will be always
processed in the same order [3], contributing to the build system
reproducibility.

[1] https://wiki.debian.org/ReproducibleBuilds
[2] https://reproducible-builds.org/docs/stable-inputs/#fn:sorted-wildcard
[3] https://reproducible-builds.org/docs/stable-inputs/

Some Linux distributions (such as Debian [1]) are striving to make their
build reproducible.

The usage of filesystem globbing as an input to the make build might
cause inconsistencies due to differences between locales [2]. This
inconsistent behavior prevents reproducible builds.

This patch sorts the Makefile inputs to ensure they will be always
processed in the same order [3], contributing to the build system
reproducibility.

[1] https://wiki.debian.org/ReproducibleBuilds
[2] https://reproducible-builds.org/docs/stable-inputs/#fn:sorted-wildcard
[3] https://reproducible-builds.org/docs/stable-inputs/
@merces
Copy link
Collaborator

merces commented Aug 18, 2021

Thanks! Count on us to make pev as easy as we can for packaging. 🙌

@merces merces merged commit 072085d into mentebinaria:master Aug 18, 2021
@davidpolverari
Copy link
Contributor Author

Thanks! Count on us to make pev as easy as we can for packaging. raised_hands

Thanks a lot! :)

@davidpolverari davidpolverari deleted the reproducible branch August 24, 2021 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants