Non-rigid ICP #12
Merged
Non-rigid ICP #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The only thing to consider here is suitesparse? Do we want to try and support suitesparse via conda? Especially since without it this is so slow? |
|
@patricksnape we should add suitesparse, but we could bring this in as is and consider adding suitesparse to conda as a secondary goal? What's blocking on the conda ports you did, is it one platform? |
|
Suitesparse is an all round headache to be honest. It also relies on BLAS/LAPACK which is another huge issue about how we deal with ensuring that BLAS/LAPACK exists on the target machine - especially on Windows. |
|
@menpobot test this please |
|
test this please |
|
I think we should get this released - it can always be refined before the next major version of menpo3d. |
|
+1 Added an issue for SuiteSparse |
|
Great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #10.
Adds an efficient implementation of Non-Rigid ICP to menpo3d.
TODO
menpo3d.correspond?)