Skip to content

Conversation

cmppoon
Copy link
Contributor

@cmppoon cmppoon commented Jul 30, 2025

Describe Your Changes

  • I noticed a bug that when you click on the assitant dropdown to select a new assistant, sometimes the assistant does not change correctly. You might have to keep trying a few times to reproduce this issue.
  • I fixed this issue by moving the onClick function to DropdownMenuItem instead of the inner div.

I hope this helps.

bug.mov

Fixes Issues

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Fixes inconsistent assistant selection in DropdownAssistant by moving onClick to DropdownMenuItem.

  • Behavior:
    • Fixes inconsistent assistant selection in DropdownAssistant by moving onClick from nested div to DropdownMenuItem.
  • Files Affected:
    • DropdownAssistant.tsx: Adjusted onClick placement for assistant selection.

This description was created by Ellipsis for ea47de0. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to ea47de0 in 43 seconds. Click for details.
  • Reviewed 27 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/DropdownAssistant.tsx:82
  • Draft comment:
    Good fix moving the onClick handler to DropdownMenuItem to reliably capture clicks. Consider if the 'cursor-pointer' class on the inner
    is still needed since the click is now on the parent. Also, ensure that accessibility (e.g., keyboard navigation/ARIA roles) is handled, likely by DropdownMenuItem.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_1NOTSiQsJNSlpLw9

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@urmauur urmauur self-assigned this Jul 31, 2025
@urmauur
Copy link
Member

urmauur commented Jul 31, 2025

Nice catch, thank u so much @cmppoon

@urmauur urmauur merged commit e48b8c9 into menloresearch:dev Jul 31, 2025
7 checks passed
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: QA
Development

Successfully merging this pull request may close these issues.

2 participants