Skip to content

Conversation

Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Jul 29, 2025

This pull request updates the .github/workflows/autoqa-template.yml file to improve the resilience of the workflow by allowing the "Upload screen recordings" step to continue even if it encounters an error.

Key change:

  • Added the continue-on-error: true property to the "Upload screen recordings" step in three different locations within the jobs: section of the workflow file. This ensures that the workflow proceeds even if the artifact upload fails. [1] [2] [3]

Important

Adds continue-on-error: true to 'Upload screen recordings' step in .github/workflows/autoqa-template.yml to ensure workflow continues despite errors.

  • Workflow Resilience:
    • Added continue-on-error: true to 'Upload screen recordings' step in .github/workflows/autoqa-template.yml.
    • Applied in windows, ubuntu, and macos job sections to ensure workflow continues despite upload errors.

This description was created by Ellipsis for 81bf10a. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 self-assigned this Jul 29, 2025
@Minh141120 Minh141120 requested a review from hiento09 July 29, 2025 08:41
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 81bf10a in 48 seconds. Click for details.
  • Reviewed 28 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/autoqa-template.yml:149
  • Draft comment:
    Good change—adding 'continue-on-error: true' ensures artifact upload failures don't block the workflow. Verify that ignoring upload errors is acceptable for your requirements.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. .github/workflows/autoqa-template.yml:296
  • Draft comment:
    The addition of 'continue-on-error: true' in the Ubuntu job is appropriate to prevent upload errors from failing the run.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. .github/workflows/autoqa-template.yml:456
  • Draft comment:
    Including 'continue-on-error: true' in the macOS job is a sound practice to allow the workflow to proceed even if the artifact upload fails.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_8Hh5i2XOIprnxcaa

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minh141120 Minh141120 merged commit 210ace7 into release/v0.6.6 Jul 29, 2025
8 of 13 checks passed
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 29, 2025
@Minh141120 Minh141120 deleted the chore/ci-upload-artifact-tolerant branch July 29, 2025 08:45
@github-actions github-actions bot added this to the v0.6.6 milestone Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants