fix: update edge case experimental feature MCP #5951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to bed4ac7 in 2 minutes and 24 seconds. Click for details.
- Reviewed
166lines of code in5files - Skipped
0files when reviewing. - Skipped posting
5draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/ChatInput.tsx:97
- Draft comment:
Typo alert: 'handleSendMesage' should be renamed to 'handleSendMessage' for clarity. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
2. web-app/src/containers/__tests__/ChatInput.test.tsx:123
- Draft comment:
The test mock now includes the 'experimentalFeatures' flag; this ensures tests mimic the new behavior correctly. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. web-app/src/hooks/useChat.ts:251
- Draft comment:
Good integration: the 'experimentalFeatures' flag is correctly used to filter available tools. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
4. web-app/src/routes/settings/general.tsx:432
- Draft comment:
The experimental features toggle properly awaits handleStopAllMCPServers before updating state. Confirm that stopping MCP servers on every toggle change is the intended behavior. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
5. web-app/src/routes/settings/mcp-servers.tsx:120
- Draft comment:
Before deleting a server, it is good practice to attempt deactivation via 'invoke("deactivate_mcp_server", …)'. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_NVnKFZLFSazcmQvV
You can customize 
qnixsynapse
approved these changes
Jul 28, 2025
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
louis-menlo
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request introduces support for experimental features in the chat application and includes updates to improve the management of MCP servers. Key changes involve conditional logic updates, test adjustments, and new server management functionality.
Experimental Features Integration:
experimentalFeaturesto theuseGeneralSettinghook and updatedChatInputto conditionally enable tools based on this setting. (web-app/src/containers/ChatInput.tsx: [1] [2]ChatInputto mock theexperimentalFeaturessetting. (web-app/src/containers/__tests__/ChatInput.test.tsx: web-app/src/containers/tests/ChatInput.test.tsxR126)experimentalFeaturesinto theuseChathook to filter available tools based on this setting. (web-app/src/hooks/useChat.ts: [1] [2]MCP Server Management Enhancements:
web-app/src/routes/settings/general.tsx: web-app/src/routes/settings/general.tsxR208-R239)web-app/src/routes/settings/general.tsx: web-app/src/routes/settings/general.tsxL398-R436)web-app/src/routes/settings/mcp-servers.tsx: web-app/src/routes/settings/mcp-servers.tsxL117-R125)Miscellaneous:
web-app/src/routes/settings/mcp-servers.tsx: web-app/src/routes/settings/mcp-servers.tsxR236-R237)Fixes Issues
https://github.com/user-attachments/assets/bcc1ad0a-dee5-4eeb-b3c3-fa4b2ff56779
https://github.com/user-attachments/assets/585b01c2-d787-4f03-b2df-1aa93d11e7bd
https://github.com/user-attachments/assets/d0aeed83-b602-4b6f-9f07-7f9f8d8d5d71
Self Checklist
Important
Integrate experimental features and enhance MCP server management in
ChatInput,useChat, and settings routes.experimentalFeaturestouseGeneralSettingand updateChatInputto conditionally enable tools based on this setting.ChatInputtests to mockexperimentalFeatures.experimentalFeaturesintouseChatto filter tools.general.tsx.general.tsx.mcp-servers.tsx.mcp-servers.tsx.This description was created by
for bed4ac7. You can customize this summary. It will automatically update as commits are pushed.