Skip to content

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Jul 25, 2025

Describe Your Changes

This pull request introduces updates to the ModelProvider hook and the ModelCapabilities enum to enhance model handling and support for additional capabilities. The most important changes include improving the logic for updating model settings and capabilities, and adding a new model to the list of supported tools.

Enhancements to model handling:

  • web-app/src/hooks/useModelProvider.ts: Improved the logic for updating models by introducing existingModel to streamline access to model properties (settings and capabilities). This ensures that existing model attributes are preserved during updates.

Support for additional tools:

  • web-app/src/types/models.ts: Added a new model, Lucy, to the DefaultToolUseSupportedModels enum, expanding the list of supported tools.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Enhances model handling in useModelProvider.ts by preserving attributes during updates and adds Lucy to supported tools in models.ts.

  • Enhancements to model handling:
    • In useModelProvider.ts, improved model update logic by introducing existingModel to preserve settings and capabilities during updates.
  • Support for additional tools:
    • In models.ts, added Lucy to DefaultToolUseSupportedModels enum, expanding supported tools list.

This description was created by Ellipsis for d2ae006. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.6.6 milestone Jul 25, 2025
@urmauur urmauur self-assigned this Jul 25, 2025
@urmauur urmauur added this to Jan Jul 25, 2025
@urmauur urmauur moved this to Needs Review in Jan Jul 25, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to d2ae006 in 1 minute and 9 seconds. Click for details.
  • Reviewed 29 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/hooks/useModelProvider.ts:77
  • Draft comment:
    Good use of assigning 'existingModel' to preserve persisted settings. Consider adding a brief comment explaining that this ensures any user changes to settings and capabilities are retained.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. web-app/src/hooks/useModelProvider.ts:82
  • Draft comment:
    Persisting 'capabilities' along with 'settings' addresses issue #5900. Ensure that new tool support defaults (e.g., for Lucy) are initialized appropriately elsewhere.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. web-app/src/types/models.ts:22
  • Draft comment:
    Added Lucy to DefaultToolUseSupportedModels. Confirm that Lucy’s default capabilities (e.g., tool support enabled) are set during model initialization.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_IMWNxbtVundAuAYG

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

Barecheck - Code coverage report

Total: 37.41%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web-app/src/hooks/useModelProvider.ts31-36, 38-39, 42-52, 54-56, 58-115, 117-128, 138-140, 142, 144-146, 149-152, 154-155, 157, 159-161, 163-176, 178-181, 183-188

Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@urmauur urmauur merged commit 7dec980 into release/v0.6.6 Jul 25, 2025
44 of 49 checks passed
@urmauur urmauur deleted the fix/persist-model-capabilities branch July 25, 2025 13:27
@github-project-automation github-project-automation bot moved this from Needs Review to QA in Jan Jul 25, 2025
@urmauur urmauur moved this from QA to Done in Jan Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

bug: Model capabilities settings do not persist after restart + Lucy model needs default tool support
3 participants