Skip to content

Conversation

Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Jul 23, 2025

This pull request enhances the autoqa-template.yml workflow by adding steps to collect and upload logs and screen recordings as artifacts for better debugging and traceability. These changes ensure that logs from different environments (Windows, Linux, macOS) are gathered and uploaded consistently.

Improvements to artifact collection and upload:

  • Log collection for all environments:

    • Added steps to collect Jan logs from environment-specific directories (Windows: $env:APPDATA, Linux: ~/.local/share, macOS: ~/Library/Application Support) and save them to a common directory for artifact upload. [1] [2] [3]
  • Artifact upload for screen recordings:

    • Introduced a step to upload screen recordings as an artifact, with a naming convention that includes build type, run number, and OS. [1] [2] [3]
  • Artifact upload for logs:

    • Added a step to upload collected Jan logs as an artifact, following the same naming convention as the screen recordings. [1] [2] [3]

Important

Enhances autoqa-template.yml to collect and upload logs and screen recordings as artifacts for Windows, Linux, and macOS environments.

  • Artifact Collection:
    • Collects Jan logs from environment-specific directories for Windows, Linux, and macOS.
    • Saves logs to autoqa/jan-logs for artifact upload.
  • Artifact Upload:
    • Uploads screen recordings with naming convention including build type, run number, and OS.
    • Uploads Jan logs with the same naming convention.

This description was created by Ellipsis for a917bd8. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 self-assigned this Jul 23, 2025
@Minh141120 Minh141120 added os: linux Linux issues os: mac Mac issues os: windows Windows issues platform: desktop Dekstop related issue labels Jul 23, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a917bd8 in 1 minute and 24 seconds. Click for details.
  • Reviewed 97 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/autoqa-template.yml:146
  • Draft comment:
    Consider using an explicit ternary operator (e.g. ${{ inputs.is_nightly ? 'jan-nightly' : 'jan' }}) for artifact names instead of using &&/|| for clarity.
  • Reason this comment was not posted:
    Confidence changes required: 50% <= threshold 50% None
2. .github/workflows/autoqa-template.yml:130
  • Draft comment:
    The steps for collecting and uploading Jan logs (and recordings) are repeated across Windows, Ubuntu, and macOS jobs. Consider refactoring these into a reusable workflow or composite action to reduce duplication.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None
3. .github/workflows/autoqa-template.yml:292
  • Draft comment:
    Ensure that the 'autoqa/recordings/' directory exists before attempting to upload artifacts to avoid potential upload failures.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_LhoHM1NxmOUMyoJo

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minh141120 Minh141120 merged commit 3a8af3c into release/v0.6.6 Jul 23, 2025
24 of 27 checks passed
@Minh141120 Minh141120 deleted the ci/autoqa-github-artifact branch July 23, 2025 07:33
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 23, 2025
@github-actions github-actions bot added this to the v0.6.6 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: linux Linux issues os: mac Mac issues os: windows Windows issues platform: desktop Dekstop related issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants