-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: jan should have a general assistant instruction #5872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 613c53c in 54 seconds. Click for details.
- Reviewed
26
lines of code in2
files - Skipped
0
files when reviewing. - Skipped posting
2
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/assistant-extension/src/index.ts:77
- Draft comment:
The default assistant instructions have been updated to a more general and user-friendly version. This improves compatibility across model types. Consider extracting this common text into a shared constant or configuration file if it is to be reused elsewhere to avoid duplication in the future. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
2. web-app/src/hooks/useAssistant.ts:23
- Draft comment:
The assistant's instructions here are updated to the same general prompt, which is clear and concise. It might be beneficial to centralize these instructions to reduce duplication and ease future maintenance. - Reason this comment was not posted:
Confidence changes required:0%
<= threshold50%
None
Workflow ID: wflow_TNTJvFzo8ciqHuuW
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 02afdaf in 1 minute and 15 seconds. Click for details.
- Reviewed
205
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/hooks/__tests__/useAssistant.test.ts:156
- Draft comment:
The expected instructions string now reflects the new generic prompt ('Only use tools when they add real value to your response'). Ensure that the default assistant configuration is updated accordingly. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative and asks the PR author to ensure that the default assistant configuration is updated. It doesn't provide a specific code suggestion or ask for a specific test to be written. It violates the rule against asking the author to ensure something is updated.
2. web-app/src/hooks/__tests__/useAssistant.test.ts:22
- Draft comment:
There are multiple whitespace and trailing comma changes which are non-functional. Ensure these formatting changes are intentional and consistent with the project’s style guidelines. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_I4lmX4PzpfseUNXf
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 36.95%Your code coverage diff: -0.01% ▾ Uncovered files and lines
|
Summary
This PR replaces Jan's hardcoded tool-use preferred assistant prompt with a general assistant instruction that works better across all model types and sizes.
Problem
The previous default assistant prompt was optimized specifically for tool usage, which caused issues:
Important
Replaces Jan's tool-focused prompt with a general instruction to improve assistant performance across models.
index.ts
anduseAssistant.ts
.useAssistant.test.ts
to reflect new prompt instructions.useAssistant.test.ts
.This description was created by
for 02afdaf. You can customize this summary. It will automatically update as commits are pushed.