Skip to content

Conversation

Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Jul 22, 2025

This pull request standardizes logging messages across the codebase by replacing emoji-based status indicators with bracketed text labels such as [SUCCESS], [FAILED], and [INFO]. This change improves log readability and consistency across different environments and platforms.

Logging Standardization:

Script Updates:


Important

Standardized logging messages by replacing emojis with text labels across various scripts and files for improved readability and consistency.

  • Logging Standardization:
    • Replaced emojis with [SUCCESS], [FAILED], and [INFO] in .github/workflows/autoqa-template.yml for installer checks and setup steps.
    • Updated autoqa/main.py to use [SUCCESS], [FAILED], and [INFO] for test result logging.
    • Unified log messages in autoqa/reportportal_handler.py with [INFO] and [FAILED] labels.
    • Adjusted logs in autoqa/test_runner.py to use [INFO] for local development and screen recording logs.
  • Script Updates:
    • Replaced emojis with [SUCCESS] and [FAILED] in autoqa/scripts/macos_download.sh and autoqa/scripts/macos_install.sh.
    • Standardized logs in autoqa/scripts/ubuntu_install.sh and autoqa/scripts/windows_install.ps1 with [SUCCESS], [FAILED], and [INFO] labels.
    • Updated autoqa/scripts/setup_permissions.sh to use [SUCCESS] for permission setup logs.

This description was created by Ellipsis for 7a96bfb. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 self-assigned this Jul 22, 2025
@Minh141120 Minh141120 added the platform: desktop Dekstop related issue label Jul 22, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to e1d9c8d in 1 minute and 59 seconds. Click for details.
  • Reviewed 329 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

Workflow ID: wflow_53ctlzE0a8l5frd2

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 7a96bfb in 1 minute and 1 seconds. Click for details.
  • Reviewed 11 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. autoqa/tests/new-user/1-user-start-chatting.txt:16
  • Draft comment:
    Good addition enforcing ASCII output. Ensure this encoding constraint aligns with other documentation and that it won’t conflict with parts of the application expecting Unicode. If this constraint is needed due to charmap issues, consider adding a brief comment explaining its rationale.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_eh3MUyQPEI17c1tP

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@Minh141120 Minh141120 merged commit 5cbd79b into release/v0.6.6 Jul 22, 2025
27 of 28 checks passed
@Minh141120 Minh141120 deleted the fix/charmap-encoding branch July 22, 2025 16:33
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 22, 2025
@github-actions github-actions bot added this to the v0.6.6 milestone Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: desktop Dekstop related issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants