-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: charmap encoding #5865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: charmap encoding #5865
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to e1d9c8d in 1 minute and 59 seconds. Click for details.
- Reviewed
329
lines of code in9
files - Skipped
0
files when reviewing. - Skipped posting
0
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_53ctlzE0a8l5frd2
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed 7a96bfb in 1 minute and 1 seconds. Click for details.
- Reviewed
11
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. autoqa/tests/new-user/1-user-start-chatting.txt:16
- Draft comment:
Good addition enforcing ASCII output. Ensure this encoding constraint aligns with other documentation and that it won’t conflict with parts of the application expecting Unicode. If this constraint is needed due to charmap issues, consider adding a brief comment explaining its rationale. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_eh3MUyQPEI17c1tP
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This pull request standardizes logging messages across the codebase by replacing emoji-based status indicators with bracketed text labels such as
[SUCCESS]
,[FAILED]
, and[INFO]
. This change improves log readability and consistency across different environments and platforms.Logging Standardization:
.github/workflows/autoqa-template.yml
: Replaced emojis in logging messages for various installer checks and setup steps with standardized text labels like[SUCCESS]
,[FAILED]
, and[WARNING]
. [1] [2] [3] [4] [5] [6] [7]autoqa/main.py
: Updated test result logging to use[SUCCESS]
and[FAILED]
labels instead of emojis, and standardized debug logs with[INFO]
. [1] [2]autoqa/reportportal_handler.py
: Unified log messages for application logs and test results with[INFO]
and[FAILED]
labels, replacing emojis. [1] [2] [3] [4] [5] [6] [7]autoqa/test_runner.py
: Adjusted local development and screen recording logs to use[INFO]
labels for consistency. [1] [2] [3]Script Updates:
autoqa/scripts/macos_download.sh
: Replaced emojis with[SUCCESS]
and[FAILED]
in download status messages.autoqa/scripts/macos_install.sh
: Standardized installation and initialization logs with[SUCCESS]
,[FAILED]
, and[INFO]
labels. [1] [2] [3]autoqa/scripts/ubuntu_install.sh
: Updated initialization wait messages to use[SUCCESS]
and[INFO]
labels.autoqa/scripts/windows_install.ps1
: Changed initialization logs to use[SUCCESS]
and[INFO]
labels.autoqa/scripts/setup_permissions.sh
: Replaced emojis with[SUCCESS]
in permission setup logs.Important
Standardized logging messages by replacing emojis with text labels across various scripts and files for improved readability and consistency.
[SUCCESS]
,[FAILED]
, and[INFO]
in.github/workflows/autoqa-template.yml
for installer checks and setup steps.autoqa/main.py
to use[SUCCESS]
,[FAILED]
, and[INFO]
for test result logging.autoqa/reportportal_handler.py
with[INFO]
and[FAILED]
labels.autoqa/test_runner.py
to use[INFO]
for local development and screen recording logs.[SUCCESS]
and[FAILED]
inautoqa/scripts/macos_download.sh
andautoqa/scripts/macos_install.sh
.autoqa/scripts/ubuntu_install.sh
andautoqa/scripts/windows_install.ps1
with[SUCCESS]
,[FAILED]
, and[INFO]
labels.autoqa/scripts/setup_permissions.sh
to use[SUCCESS]
for permission setup logs.This description was created by
for 7a96bfb. You can customize this summary. It will automatically update as commits are pushed.