-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: custom tauri nsis template CheckIfAppIsRunning macro #5840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…earch/jan into fix/tauri-tauri-windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 16ac268 in 1 minute and 47 seconds. Click for details.
- Reviewed
22
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
2
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/tauri.bundle.windows.nsis.template:626
- Draft comment:
Updated CheckIfAppIsRunning macro now passes "${MAINBINARYNAME}.exe" and "${PRODUCTNAME}". This improves the specificity of the running app check. Ensure that concatenating '.exe' is intentional (i.e. MAINBINARYNAME does not already include an extension). - Reason this comment was not posted:
Comment looked like it was already resolved.
2. src-tauri/tauri.bundle.windows.nsis.template:753
- Draft comment:
Consistently passing "${MAINBINARYNAME}.exe" and "${PRODUCTNAME}" to CheckIfAppIsRunning in the Uninstall section ensures the check is app-specific. Verify the macro definition supports these parameters. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
The comment is asking the author to verify the macro definition, which is against the rules. It does not provide a specific suggestion or point out a clear issue with the code. Therefore, it should be removed.
Workflow ID: wflow_1WPhgQ7yMsPvr94f
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
Barecheck - Code coverage reportTotal: 35%Your code coverage diff: -0.01% ▾ ✅ All code changes are covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request updates the
src-tauri/tauri.bundle.windows.nsis.template
file to improve the handling of application-specific parameters when checking if the app is running during installation and uninstallation.Improvements to application-specific handling:
CheckIfAppIsRunning
macro in theSection Install
to include the${MAINBINARYNAME}.exe
and${PRODUCTNAME}
parameters, ensuring the check is specific to the app being installed.CheckIfAppIsRunning
macro in theSection Uninstall
to include the${MAINBINARYNAME}.exe
and${PRODUCTNAME}
parameters, ensuring the check is specific to the app being uninstalled.Important
Update
CheckIfAppIsRunning
macro in NSIS template to include app-specific parameters for install and uninstall sections.CheckIfAppIsRunning
macro inSection Install
to include${MAINBINARYNAME}.exe
and${PRODUCTNAME}
parameters.CheckIfAppIsRunning
macro inSection Uninstall
to include${MAINBINARYNAME}.exe
and${PRODUCTNAME}
parameters.This description was created by
for 16ac268. You can customize this summary. It will automatically update as commits are pushed.