Skip to content

Conversation

Minh141120
Copy link
Member

@Minh141120 Minh141120 commented Jul 21, 2025

This pull request updates the src-tauri/tauri.bundle.windows.nsis.template file to improve the handling of application-specific parameters when checking if the app is running during installation and uninstallation.

Improvements to application-specific handling:

  • Updated the CheckIfAppIsRunning macro in the Section Install to include the ${MAINBINARYNAME}.exe and ${PRODUCTNAME} parameters, ensuring the check is specific to the app being installed.
  • Updated the CheckIfAppIsRunning macro in the Section Uninstall to include the ${MAINBINARYNAME}.exe and ${PRODUCTNAME} parameters, ensuring the check is specific to the app being uninstalled.

Important

Update CheckIfAppIsRunning macro in NSIS template to include app-specific parameters for install and uninstall sections.

  • NSIS Template Update:
    • Updated CheckIfAppIsRunning macro in Section Install to include ${MAINBINARYNAME}.exe and ${PRODUCTNAME} parameters.
    • Updated CheckIfAppIsRunning macro in Section Uninstall to include ${MAINBINARYNAME}.exe and ${PRODUCTNAME} parameters.

This description was created by Ellipsis for 16ac268. You can customize this summary. It will automatically update as commits are pushed.

@Minh141120 Minh141120 added this to the v0.6.6 milestone Jul 21, 2025
@Minh141120 Minh141120 self-assigned this Jul 21, 2025
@Minh141120 Minh141120 added this to Jan Jul 21, 2025
@Minh141120 Minh141120 added os: windows Windows issues platform: desktop Dekstop related issue labels Jul 21, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 16ac268 in 1 minute and 47 seconds. Click for details.
  • Reviewed 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. src-tauri/tauri.bundle.windows.nsis.template:626
  • Draft comment:
    Updated CheckIfAppIsRunning macro now passes "${MAINBINARYNAME}.exe" and "${PRODUCTNAME}". This improves the specificity of the running app check. Ensure that concatenating '.exe' is intentional (i.e. MAINBINARYNAME does not already include an extension).
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. src-tauri/tauri.bundle.windows.nsis.template:753
  • Draft comment:
    Consistently passing "${MAINBINARYNAME}.exe" and "${PRODUCTNAME}" to CheckIfAppIsRunning in the Uninstall section ensures the check is app-specific. Verify the macro definition supports these parameters.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is asking the author to verify the macro definition, which is against the rules. It does not provide a specific suggestion or point out a clear issue with the code. Therefore, it should be removed.

Workflow ID: wflow_1WPhgQ7yMsPvr94f

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

Barecheck - Code coverage report

Total: 35%

Your code coverage diff: -0.01% ▾

✅ All code changes are covered

Copy link
Contributor

@hiento09 hiento09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Minh141120 Minh141120 requested a review from qnixsynapse July 21, 2025 13:52
@Minh141120 Minh141120 merged commit 9ea0815 into release/v0.6.6 Jul 21, 2025
18 of 21 checks passed
@Minh141120 Minh141120 deleted the fix/tauri-tauri-windows branch July 21, 2025 13:54
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
os: windows Windows issues platform: desktop Dekstop related issue
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants