-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add Hugging Face as a provider #5808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add Hugging Face as a provider #5808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 6ce26b7 in 1 minute and 22 seconds. Click for details.
- Reviewed
209
lines of code in5
files - Skipped
1
files when reviewing. - Skipped posting
5
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/engine-management-extension/engines.mjs:6
- Draft comment:
Hugging Face provider imported and added to both engines and models lists. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%
<= threshold50%
This comment is purely informative, stating what was done without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest improvements.
2. extensions/engine-management-extension/models/huggingface.json:1
- Draft comment:
Hugging Face model definitions are valid; consider aligning descriptions with mock data if needed. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
3. extensions/engine-management-extension/resources/huggingface.json:10
- Draft comment:
Resource config with transform_req/transform_resp templates looks good; verify that the key list meets provider requirements. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
4. web-app/src/lib/utils.ts:9
- Draft comment:
Hugging Face cases added to getProviderLogo and getProviderTitle functions correctly. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
5. web-app/src/mock/data.ts:285
- Draft comment:
Hugging Face provider entry added with appropriate settings and model list; consider aligning model descriptions with definitions. - Reason this comment was not posted:
Confidence changes required:33%
<= threshold50%
None
Workflow ID: wflow_GxoUXt6eoLVjMfqB
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, @gary149! We'd love to proceed with the merge and then apply a few minor adjustments. You're correct that we're deprecating engine-management-extension and moving the provider to be part of the app so it can be treated as first-class provider.
Add Hugging Face Inference Provider as remote engine.
Note: If I understand correctly, we'd need to be registered in token.js to be treated as a first-class provider (non-deletable)?
Btw feel free to take over on this (one cool thing is that free users get a few free messages to try out)
Important
Adds Hugging Face as a new inference provider with model configurations, API settings, and utility support.
engines.mjs
.models/huggingface.json
.resources/huggingface.json
.getProviderLogo()
andgetProviderTitle()
inutils.ts
to support Hugging Face.data.ts
.This description was created by
for 6ce26b7. You can customize this summary. It will automatically update as commits are pushed.