Skip to content

Conversation

qnixsynapse
Copy link
Contributor

@qnixsynapse qnixsynapse commented Jul 17, 2025

This change enables Jan to render reasoning content which it normally parses using non deepseek style tags.


Important

Adds --reasoning-format none argument in index.ts to disable reasoning content rendering.

  • Behavior:
    • Adds --reasoning-format none argument in load() method in index.ts to disable reasoning content rendering.
  • Misc:
    • No other files or functions are affected by this change.

This description was created by Ellipsis for a8d1d2b. You can customize this summary. It will automatically update as commits are pushed.

@qnixsynapse qnixsynapse requested a review from louis-menlo July 17, 2025 15:45
@qnixsynapse qnixsynapse changed the title fix: Add --reasoning-format none to support rendering of reasoning co… fix: Add --reasoning-format none to support rendering of reasoning content Jul 17, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to a8d1d2b in 1 minute and 1 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. extensions/llamacpp-extension/src/index.ts:802
  • Draft comment:
    Added '--reasoning-format none'. Consider adding an inline comment explaining why this flag is hardcoded and whether it should be configurable in the future.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_F6OqKsDj4idSu2Q6

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

Barecheck - Code coverage report

Total: 35.34%

Your code coverage diff: 0.00% ▴

✅ All code changes are covered

Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qnixsynapse qnixsynapse merged commit bcb6037 into release/v0.6.6 Jul 18, 2025
26 of 27 checks passed
@qnixsynapse qnixsynapse deleted the fix/reasoning_content branch July 18, 2025 02:52
@github-project-automation github-project-automation bot moved this to QA in Jan Jul 18, 2025
@github-actions github-actions bot added this to the v0.6.6 milestone Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants