🐛fix: render streaming token speed based on thread ID & assistant metadata

[urmauur]

Describe Your Changes

This pull request introduces updates to improve conditional rendering and state management in the ThreadContent component and refines the structure of the assistant metadata in the useMessages hook. The changes enhance functionality and ensure more precise handling of data.

Updates to ThreadContent component:

• Improved conditional rendering logic to ensure the hidden class is applied only when streamingContent.thread_id matches item.thread_id, enhancing accuracy in UI behavior. (web-app/src/containers/ThreadContent.tsx, web-app/src/containers/ThreadContent.tsxL366-R369)
• Updated the streaming prop in the TokenSpeedIndicator component to include a thread ID match check, ensuring proper streaming indication. (web-app/src/containers/ThreadContent.tsx, web-app/src/containers/ThreadContent.tsxL442-R457)

Refinements in useMessages hook:

• Expanded the assistant metadata structure by adding explicit fields (id, name, avatar, and instructions) with default values, improving data integrity and clarity. (web-app/src/hooks/useMessages.ts, web-app/src/hooks/useMessages.tsL37-R42)

Fixes Issues

• Closes #
• Closes #

Self Checklist

• Added relevant comments, esp in complex areas
• Updated docs (for bug fixes / features)
• Created issues for follow-up changes or refactoring needed

---

Important

Fixes rendering logic in ThreadContent.tsx and refines assistant metadata in useMessages.ts for accurate UI behavior and data integrity.

• Behavior:
  • ThreadContent.tsx: Improved conditional rendering to apply hidden class only when streamingContent.thread_id matches item.thread_id.
  • TokenSpeedIndicator streaming prop updated to check for thread ID match.
• Metadata:
  • useMessages.ts: Expanded assistant metadata with fields id, name, avatar, instructions, and parameters with default values.

^{This description was created by for 82fc6d1. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to a0389fc in 53 seconds. Click for details.

• Reviewed 55 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 3 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/containers/ThreadContent.tsx:366

• Draft comment:
  Good use of adding a thread ID check before applying 'hidden'. Ensure that both streamingContent and item.thread_id are always defined and of the same type.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

2. web-app/src/containers/ThreadContent.tsx:445

• Draft comment:
  The TokenSpeedIndicator now correctly checks the thread_id. This ensures the indicator is shown only for the correct message stream.
• Reason this comment was not posted:
  Confidence changes required: 0% <= threshold 50% None

3. web-app/src/hooks/useMessages.ts:37

• Draft comment:
  Refining the assistant metadata structure improves clarity. Consider verifying that default empty strings meet downstream type expectations.
• Reason this comment was not posted:
  Confidence changes required: 20% <= threshold 50% None

Workflow ID: wflow_tZvqUH8LyJWe3aSv

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}

[louis-menlo]

LGTM!!!

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed 82fc6d1 in 1 minute and 27 seconds. Click for details.

• Reviewed 12 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. web-app/src/hooks/useMessages.ts:42

• Draft comment:
  Ensure the default value for 'parameters' is of the intended type. If 'parameters' is expected to be an object or array, consider using {} or [] instead of an empty string.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The code shows a clear pattern of using empty strings as defaults for all assistant properties. Without seeing the type definition of currentAssistant.parameters or how this data is used elsewhere, suggesting a change to {} could actually break consistency or introduce type mismatches. The current approach seems intentionally consistent. I could be wrong about the parameters field - maybe it really is meant to be an object and this is a genuine bug. The type information would make this clear. However, without seeing strong evidence that parameters should be an object (like type definitions or usage), changing the consistent pattern could introduce problems rather than solve them. The comment should be deleted as it makes assumptions about types without clear evidence and the code shows intentional consistency in using empty strings as defaults.

Workflow ID: wflow_LrtneZNgSSlF2qpQ

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}