Skip to content

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Jun 5, 2025

Describe Your Changes

This pull request refines the DropdownModelProvider component in web-app/src/containers/DropdownModelProvider.tsx to improve its functionality and user experience. The changes include adjustments to the grouping logic for providers, updates to the dropdown styling and behavior based on search state, and removal of unnecessary icons and checks for cleaner UI.

Functional Improvements:

  • Enhanced grouping logic: Providers are now displayed even if they don't have models, as long as they are active and the user isn't searching. This ensures better visibility of active providers.
  • Added conditional rendering for providers with no models: Displays an empty message when a provider has no available models, improving clarity for the user.

UI and Styling Updates:

  • Adjusted dropdown styling: The dropdown's dimensions and behavior now dynamically adapt based on whether the user is searching, improving usability.

Code Cleanup:

  • Removed IconCheck: Eliminated unnecessary check icons for selected models, simplifying the UI.
  • Updated dependencies: Removed unused import of IconCheck from @tabler/icons-react.

Fixes Issues

Screenshot 2025-06-05 at 11 18 28
Screenshot 2025-06-05 at 11 18 45
Screenshot 2025-06-05 at 11 17 58

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Refines DropdownModelProvider to enhance provider grouping logic, adapt dropdown styling based on search state, and remove unnecessary icons.

  • Functional Improvements:
    • Enhanced grouping logic in DropdownModelProvider: Active providers are shown even without models when not searching.
    • Conditional rendering for providers with no models: Displays an empty message for clarity.
  • UI and Styling Updates:
    • Adjusted dropdown styling in DropdownModelProvider: Dimensions and behavior adapt based on search state.
  • Code Cleanup:
    • Removed IconCheck from DropdownModelProvider: Simplified UI by eliminating check icons.
    • Removed unused import of IconCheck from @tabler/icons-react.

This description was created by Ellipsis for 9f3df39. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.5.18 milestone Jun 5, 2025
@urmauur urmauur requested review from samhvw8 and louis-menlo June 5, 2025 04:21
@urmauur urmauur self-assigned this Jun 5, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caution

Changes requested ❌

Reviewed everything up to 9f3df39 in 1 minute and 42 seconds. Click for details.
  • Reviewed 159 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/containers/DropdownModelProvider.tsx:227
  • Draft comment:
    Verify that the updated PopoverContent styling (width change to 'w-60', dynamic height, and conditional 'side' and 'avoidCollisions' props) meets the intended design.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is asking the PR author to verify that the styling changes meet the intended design, which falls under the category of asking for confirmation of intention. This violates the rule against asking the PR author to confirm their intention or ensure the behavior is intended.

Workflow ID: wflow_Ze1NAszqyH2LAT9U

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

filteredItems.forEach((item) => {
const providerKey = item.provider.provider
console.log(providerKey, 'providerKey')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the debug console.log(providerKey) before merging. It appears to be leftover from debugging.

Suggested change
console.log(providerKey, 'providerKey')

</div>
{models.length === 0 ? (
// Show message when provider has no available models
<></>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider displaying a user-friendly message for providers with no models instead of rendering an empty fragment.

Suggested change
<></>
<div className="py-2 px-4 text-sm text-main-view-fg/60">No models available for this provider</div>

@urmauur urmauur merged commit 8ee4969 into release/v0.5.18 Jun 5, 2025
30 checks passed
@urmauur urmauur deleted the fix/dropdown-model-position branch June 5, 2025 05:07
@github-project-automation github-project-automation bot moved this to QA in Jan Jun 5, 2025
@david-menloai david-menloai moved this from QA to Done in Jan Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants