Skip to content

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented May 30, 2025

Describe Your Changes

This pull request includes a small change to the web-app/src/styles/markdown.css file. The change removes the width: max-content; property from the table styling.

Fixes Issues

https://discord.com/channels/1107178041848909847/1377905799044665365/1377905799044665365

Screenshot 2025-05-30 at 14 37 48
Screenshot 2025-05-30 at 14 38 02

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

Important

Remove width: max-content; from table in markdown.css to fix floating content issue in markdown tables.

  • CSS Changes:
    • Remove width: max-content; from table in markdown.css to prevent floating content in markdown tables.

This description was created by Ellipsis for 2b0e817. You can customize this summary. It will automatically update as commits are pushed.

@urmauur urmauur added this to the v0.5.18 milestone May 30, 2025
@urmauur urmauur requested a review from louis-menlo May 30, 2025 07:39
@urmauur urmauur self-assigned this May 30, 2025
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 2b0e817 in 41 seconds. Click for details.
  • Reviewed 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. web-app/src/styles/markdown.css:127
  • Draft comment:
    Removing 'width: max-content' seems appropriate to prevent table floating. Ensure the table still displays well on various screen sizes.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_fiHqfx0oyPoUPsbT

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@urmauur urmauur merged commit 120de81 into release/v0.5.18 May 30, 2025
19 checks passed
@urmauur urmauur deleted the fix/table-render-markdown branch May 30, 2025 10:33
@github-project-automation github-project-automation bot moved this to QA in Jan May 30, 2025
@github-actions github-actions bot modified the milestones: v0.5.18, v0.5.19 May 30, 2025
@david-menloai david-menloai moved this from QA to Done in Jan Jun 20, 2025
@LazyYuuki LazyYuuki removed this from the v0.7.2 milestone Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants