fix: state model threadId #5144
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Your Changes
This pull request refactors the
ThreadDetail
component inweb-app/src/routes/threads/$threadId.tsx
to simplify thread data subscription and improve state management. The most important changes include removing thegetThreadById
function and directly subscribing to thread data using a state selector.Refactor thread data subscription:
getThreadById
function from theuseThreads
hook and replaced it with direct subscription to thread data usinguseShallow
for improved reactivity.Simplify state management:
useThreads
destructuring to remove the unusedgetThreadById
function.Fixes Issues
Self Checklist
Important
Refactor
ThreadDetail
component in$threadId.tsx
to removegetThreadById
and directly subscribe to thread data usinguseShallow
.getThreadById
fromuseThreads
inThreadDetail
component in$threadId.tsx
.useShallow
for improved reactivity.useThreads
destructuring by removing unusedgetThreadById
.This description was created by
for 716e376. You can customize this summary. It will automatically update as commits are pushed.