-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix: ci remove pr review trigger #5105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed everything up to a6625e3 in 1 minute and 11 seconds. Click for details.
- Reviewed
13
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_ZbFZHtI4M69GmZM3
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
@@ -12,8 +12,6 @@ on: | |||
- none | |||
- aws-s3 | |||
default: none | |||
pull_request_review: | |||
types: [submitted] | |||
pull_request: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed the pull_request_review
trigger, but note that the comment-pr-build-url
job (line 201) still has an if-condition checking for github.event_name == 'pull_request_review'
. This job will never run with the updated triggers; consider removing or updating this job to align with the new workflow triggers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed 90990db in 1 minute and 52 seconds. Click for details.
- Reviewed
43
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
1
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .github/workflows/jan-electron-build-nightly.yml:208
- Draft comment:
The active 'Comment build URL on PR' step uses the 'gh pr comment' command but no longer installs the GitHub CLI (gh) since its setup step was removed. Ensure gh is installed if this step should run, or remove the step entirely. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_sg2DrceoBsElJZNy
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
# - name: Set up GitHub CLI | ||
# run: | | ||
# curl -sSL https://github.com/cli/cli/releases/download/v2.33.0/gh_2.33.0_linux_amd64.tar.gz | tar xz | ||
# sudo cp gh_2.33.0_linux_amd64/bin/gh /usr/local/bin/ | ||
|
||
- name: Comment build URL on PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR removes the 'comment-pr-build-url' job by commenting its header and its GitHub CLI setup step; however, the subsequent step 'Comment build URL on PR' remains active. This likely results in an orphaned step outside of any job. Please remove or properly nest this step.
90990db
to
b9fbb7a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Changes requested ❌
Reviewed b9fbb7a in 1 minute and 16 seconds. Click for details.
- Reviewed
59
lines of code in1
files - Skipped
0
files when reviewing. - Skipped posting
0
draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
Workflow ID: wflow_NC8GkCAOQdwM8h5Q
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
run: | | ||
curl -sSL https://github.com/cli/cli/releases/download/v2.33.0/gh_2.33.0_linux_amd64.tar.gz | tar xz | ||
sudo cp gh_2.33.0_linux_amd64/bin/gh /usr/local/bin/ | ||
# comment-pr-build-url: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing the commented-out comment-pr-build-url
job entirely if it’s no longer needed. Keeping obsolete code as comments can clutter the file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks mannn!
This pull request modifies the GitHub Actions workflow file
.github/workflows/jan-electron-build-nightly.yml
to streamline the triggering conditions for the workflow.Workflow trigger updates:
pull_request_review
trigger that activated the workflow on review submission. The workflow now triggers only forpull_request
events targeting branches matching therelease/**
pattern.Important
Removed
pull_request_review
trigger and related job from GitHub Actions workflow to streamline triggers forrelease/**
branches.pull_request_review
trigger from.github/workflows/jan-electron-build-nightly.yml
.pull_request
events forrelease/**
branches.comment-pr-build-url
is commented out, which was dependent onpull_request_review
events.This description was created by
for b9fbb7a. You can customize this summary. It will automatically update as commits are pushed.