Skip to content

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented May 20, 2025

Describe Your Changes

This pull request introduces several updates to the ChatInput and DropdownAssistant components, along with minor adjustments in the ThreadDetail route. The changes focus on improving user experience by refining UI behavior, temporarily hiding unused features, and enhancing the loading experience for specific models. Below is a breakdown of the most important changes:

Changes to ChatInput Component:

  • Removed the unused IconMicrophone import and temporarily commented out the microphone feature in the UI. This suggests the feature is being hidden for now but may return in the future. [1] [2]
  • Introduced conditional rendering for the ModelLoader component to display a loading indicator when the llama.cpp model is selected and still loading. [1] [2]
  • Added a console.log(model) statement, likely for debugging purposes. This should be removed before deploying to production.

Changes to DropdownAssistant Component:

  • Adjusted the padding and alignment of dropdown menu items to improve the visual layout and spacing. [1] [2]

Changes to ThreadDetail Route:

  • Removed the ModelLoader component and its associated logic from the ThreadDetail route, centralizing the loading behavior within the ChatInput component. This simplifies the code and avoids duplication. [1] [2] [3]

Fixes Issues

Screenshot 2025-05-20 at 11 09 01
Screenshot 2025-05-20 at 11 07 41

  • Closes #
  • Closes #

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added this to the v0.5.18 milestone May 20, 2025
@urmauur urmauur requested a review from louis-menlo May 20, 2025 04:30
@urmauur urmauur self-assigned this May 20, 2025
Copy link
Contributor

@louis-menlo louis-menlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@urmauur urmauur merged commit 76827d4 into release/v0.5.18 May 20, 2025
5 checks passed
@urmauur urmauur deleted the chore/model-loading branch May 20, 2025 05:44
@github-project-automation github-project-automation bot moved this to QA in Jan May 20, 2025
@david-menloai david-menloai moved this from QA to Done in Jan Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants