UPDATE: add reasoning column and update some docs.#39
Merged
JieZhou000 merged 3 commits intoacs-1230-privatefrom Dec 20, 2023
Merged
UPDATE: add reasoning column and update some docs.#39JieZhou000 merged 3 commits intoacs-1230-privatefrom
JieZhou000 merged 3 commits intoacs-1230-privatefrom
Conversation
mengaims
reviewed
Dec 19, 2023
| #suppress "@azure-tools/typespec-azure-core/documentation-required" "MUST fix in next update" | ||
| @added(ContentSafety.Versions.v2023_11_30_Preview) | ||
| @doc("domain category.") | ||
| @doc("Domain category.") |
Owner
There was a problem hiding this comment.
I suggest remove the "category" wording here even in description, this will cause a lot of confusion.
|
|
||
| @doc("The reason or explanation for identifying the text as ungrounded.") | ||
| @doc("The explanation for identifying the text as ungrounded.") | ||
| reason: string; |
| @doc("A value indicating if the output includes an explanation for the identified ungroundedness.") | ||
| reasoning?: boolean; | ||
|
|
||
| @doc("Connection details for the GPT resource.") |
Owner
There was a problem hiding this comment.
It's better to have a detailed description here that this field will be only valid when reasoning set to true.
| groundingSources: string[]; | ||
|
|
||
| @doc("GPT resource connection information.") | ||
| @doc("A value indicating if the output includes an explanation for the identified ungroundedness.") |
Owner
There was a problem hiding this comment.
Better to give default value here.
mengaims
approved these changes
Dec 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.