DB-1953 remove null check, because null values are a feature in plotly #42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@JansenNick, your change cause TypeScript errors, please fix the types and run P.S. Thank you for PR |
iobuhov
requested changes
Nov 2, 2022
Co-authored-by: Illia Obukhau <[email protected]>
iobuhov
approved these changes
Nov 2, 2022
rahmanunver
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains
What is the purpose of this PR?
Plotly allows for
nullin your data and will by default fill up gaps. It also has the option to setconnectgapsto false so you can have a line with gaps in between. https://plotly.com/javascript/line-charts/#connect-gaps-between-dataThe code that this pull request removes prevents
nullending up in your data set, even though plotly can handle this. Right now if you would have an empty value in your dataset the chart would not render.By removing this code, the chart will still render when you have an empty value in your data, by default it will connect the gaps and you will have to option to turn this off.