Skip to content

[WC-2818] ComboBox: fix RTL issues #1944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WC-2818] ComboBox: fix RTL issues #1944

wants to merge 1 commit into from

Conversation

@yordan-st
Copy link
Contributor

Pull request type

Bug fix (non-breaking change which fixes an issue)

Description

  • Fixed an issue where right-to-left text orientation would break layout and spacing of some elements. To fix this, we implemented CSS logical properties

What should be covered while testing?

  • Set language to RTL language
  • Observe any layout differences in the combobox

@yordan-st yordan-st requested a review from a team as a code owner October 20, 2025 13:36
@yordan-st yordan-st force-pushed the fix/WC-2818_combobox-rtl-issue branch from e2be844 to fe0c3d7 Compare October 20, 2025 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gjulivan gjulivan gjulivan approved these changes

@leonardomendix leonardomendix leonardomendix approved these changes

Assignees

No one assigned

Labels

combobox-web

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yordan-st @gjulivan @leonardomendix