Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor add code comment #95

Merged
merged 1 commit into from
Aug 14, 2022
Merged

Minor add code comment #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions ...ink/src/main/java/io/debezium/server/iceberg/tableoperator/IcebergTableWriterFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,32 +29,56 @@ public class IcebergTableWriterFactory {
@ConfigProperty(name = "debezium.sink.iceberg.upsert-keep-deletes", defaultValue = "true")
boolean upsertKeepDeletes;

private static int partitionId() {
return Integer.parseInt(dtFormater.format(Instant.now()));
}

public BaseTaskWriter<Record> create(Table icebergTable) {

// file format of the table parquet, orc ...
FileFormat format = IcebergUtil.getTableFileFormat(icebergTable);
// appender factory
GenericAppenderFactory appenderFactory = IcebergUtil.getTableAppender(icebergTable);
int partitionId = Integer.parseInt(dtFormater.format(Instant.now()));
OutputFileFactory fileFactory = OutputFileFactory.builderFor(icebergTable, partitionId, 1L)
OutputFileFactory fileFactory = OutputFileFactory.builderFor(icebergTable, partitionId(), 1L)
.defaultSpec(icebergTable.spec()).format(format).build();
// equality Field Ids
List<Integer> equalityFieldIds = new ArrayList<>(icebergTable.schema().identifierFieldIds());

BaseTaskWriter<Record> writer;

// 1. TABLE DONT HAVE identifierFieldIds
// 2. OR RUNNING APPEND MODE
// THEN USE APPEND WRITERS
if (icebergTable.schema().identifierFieldIds().isEmpty() || !upsert) {

if (upsert) {
// running in upsert mode but table dont have identifierFieldIds to do delete!
LOGGER.info("Table don't have Pk defined upsert is not possible falling back to append!");
}

if (icebergTable.spec().isUnpartitioned()) {
// table is un partitioned use un partitioned append writer
writer = new UnpartitionedWriter<>(
icebergTable.spec(), format, appenderFactory, fileFactory, icebergTable.io(), Long.MAX_VALUE);

} else {
// table is partitioned use partitioned append writer
writer = new PartitionedAppendWriter(
icebergTable.spec(), format, appenderFactory, fileFactory, icebergTable.io(), Long.MAX_VALUE, icebergTable.schema());
}
} else if (icebergTable.spec().isUnpartitioned()) {

}

// ITS UPSERT MODE
// AND TABLE HAS identifierFieldIds
// USE DELTA WRITERS
else if (icebergTable.spec().isUnpartitioned()) {
// running with upsert mode + un partitioned table
writer = new UnpartitionedDeltaWriter(icebergTable.spec(), format, appenderFactory, fileFactory,
icebergTable.io(),
Long.MAX_VALUE, icebergTable.schema(), equalityFieldIds, true, upsertKeepDeletes);
} else {
// running with upsert mode + partitioned table
writer = new PartitionedDeltaWriter(icebergTable.spec(), format, appenderFactory, fileFactory,
icebergTable.io(),
Long.MAX_VALUE, icebergTable.schema(), equalityFieldIds, true, upsertKeepDeletes);
Expand Down