Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix __source_ts_ms values with 0 conversion and enable mongodb test #292

Merged
merged 4 commits into from
Mar 13, 2024
Merged

Fix __source_ts_ms values with 0 conversion and enable mongodb test #292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12662c5
Update IcebergChangeConsumerMangodbTest.java
ismailsimsek Mar 13, 2024
d4339d4
Update SourceMangoDB.java
ismailsimsek Mar 13, 2024
f21b2ee
Update IcebergChangeEvent.java
ismailsimsek Mar 13, 2024
740e307
Update SourceMangoDB.java
ismailsimsek Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...zium-server-iceberg-sink/src/main/java/io/debezium/server/iceberg/IcebergChangeEvent.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ private static Object jsonValToIcebergVal(Types.NestedField field, JsonNode node
val = node.isValueNode() ? UUID.fromString(node.asText(null)) : UUID.fromString(node.toString());
break;
case TIMESTAMP:
if (node.isLong() && TS_MS_FIELDS.contains(field.name())) {
if ((node.isLong() || node.isNumber()) && TS_MS_FIELDS.contains(field.name())) {
val = OffsetDateTime.ofInstant(Instant.ofEpochMilli(node.longValue()), ZoneOffset.UTC);
} else if (node.isTextual()) {
val = OffsetDateTime.parse(node.asText());
Expand Down
1 change: 0 additions & 1 deletion ...eberg-sink/src/test/java/io/debezium/server/iceberg/IcebergChangeConsumerMangodbTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
* @author Ismail Simsek
*/
@QuarkusTest
@Disabled // @TODO fix
@QuarkusTestResource(value = S3Minio.class, restrictToAnnotatedClass = true)
@QuarkusTestResource(value = SourceMangoDB.class, restrictToAnnotatedClass = true)
@TestProfile(IcebergChangeConsumerMangodbTest.TestProfile.class)
Expand Down
2 changes: 2 additions & 0 deletions ...er-iceberg-sink/src/test/java/io/debezium/server/iceberg/testresources/SourceMangoDB.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;

import java.time.Duration;
import java.util.List;
import java.util.Map;
import java.util.concurrent.ConcurrentHashMap;

Expand All @@ -31,6 +32,7 @@ public class SourceMangoDB implements QuarkusTestResourceLifecycleManager {

@Override
public Map<String, String> start() {
container.setPortBindings(List.of(MONGODB_PORT+":"+MONGODB_PORT));
container.withExposedPorts(MONGODB_PORT).start();

Map<String, String> params = new ConcurrentHashMap<>();
Expand Down