Add option to change case of destination/iceberg table names

memiiso · Jul 24, 2024 · c073eff · c073eff
1 parent 06fb519
commit c073eff
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 10 deletions.
diff --git a/...m-server-iceberg-sink/src/main/java/io/debezium/server/iceberg/IcebergChangeConsumer.java b/...m-server-iceberg-sink/src/main/java/io/debezium/server/iceberg/IcebergChangeConsumer.java
@@ -84,10 +84,10 @@ public class IcebergChangeConsumer extends BaseChangeConsumer implements Debeziu
   protected Optional<String> destinationRegexp;
   @ConfigProperty(name = "debezium.sink.iceberg.destination-regexp-replace", defaultValue = "")
   protected Optional<String> destinationRegexpReplace;
-  @ConfigProperty(name = "debezium.sink.iceberg.destination-uppercase-names", defaultValue = "false")
-  protected boolean destinationUppercaseNames;
-  @ConfigProperty(name = "debezium.sink.iceberg.destination-lowercase-names", defaultValue = "false")
-  protected boolean destinationLowercaseNames;
+  @ConfigProperty(name = "debezium.sink.iceberg.destination-uppercase-table-names", defaultValue = "false")
+  protected boolean destinationUppercaseTableNames;
+  @ConfigProperty(name = "debezium.sink.iceberg.destination-lowercase-table-names", defaultValue = "false")
+  protected boolean destinationLowercaseTableNames;
   @ConfigProperty(name = "debezium.sink.iceberg.table-prefix", defaultValue = "")
   Optional<String> tablePrefix;
   @ConfigProperty(name = "debezium.sink.iceberg.table-namespace", defaultValue = "default")
@@ -208,9 +208,9 @@ public TableIdentifier mapDestination(String destination) {
         .replaceAll(destinationRegexp.orElse(""), destinationRegexpReplace.orElse(""))
         .replace(".", "_");
 
-    if (destinationUppercaseNames) {
+    if (destinationUppercaseTableNames) {
       return TableIdentifier.of(Namespace.of(namespace.toUpperCase()), (tablePrefix.orElse("") + tableName).toUpperCase());
-    } else if (destinationLowercaseNames) {
+    } else if (destinationLowercaseTableNames) {
       return TableIdentifier.of(Namespace.of(namespace.toLowerCase()), (tablePrefix.orElse("") + tableName).toLowerCase());
     } else {
       return TableIdentifier.of(Namespace.of(namespace), tablePrefix.orElse("") + tableName);

diff --git a/...rver-iceberg-sink/src/test/java/io/debezium/server/iceberg/IcebergChangeConsumerTest.java b/...rver-iceberg-sink/src/test/java/io/debezium/server/iceberg/IcebergChangeConsumerTest.java
@@ -334,11 +334,11 @@ public void testPartitionedTable() {
   public void testMapDestination() {
     assertEquals(TableIdentifier.of(Namespace.of(namespace), "debeziumcdc_table"), icebergConsumer.mapDestination("table1"));
     assertEquals(TableIdentifier.of(Namespace.of(namespace), "debeziumcdc_table"), icebergConsumer.mapDestination("table2"));
-    icebergConsumer.destinationUppercaseNames = true;
-    icebergConsumer.destinationLowercaseNames = false;
+    icebergConsumer.destinationUppercaseTableNames = true;
+    icebergConsumer.destinationLowercaseTableNames = false;
     assertEquals(TableIdentifier.of(Namespace.of(namespace.toUpperCase()), "DEBEZIUMCDC_TABLE_LOWERCASE"), icebergConsumer.mapDestination("table_lowercase"));
-    icebergConsumer.destinationUppercaseNames = false;
-    icebergConsumer.destinationLowercaseNames = true;
+    icebergConsumer.destinationUppercaseTableNames = false;
+    icebergConsumer.destinationLowercaseTableNames = true;
     assertEquals(TableIdentifier.of(Namespace.of(namespace.toLowerCase()), "debeziumcdc_table_camelcase"), icebergConsumer.mapDestination("table_CamelCase"));
   }