This repository has been archived by the owner on Jun 8, 2024. It is now read-only.
feat: make model customizable #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cachho
suggested changes
Jul 23, 2023
| constructor(appConfig: AppConfig | null = null) { | ||
| // If a model is defined in the config, set it as the model | ||
| if (appConfig?.model) { | ||
| this.model = appConfig.model; |
There was a problem hiding this comment.
With this, there's no default model, right? We do need a default model, to not make this change breaking.
There was a problem hiding this comment.
default is 'gpt-3.5-turbo', set on line 40. this is the model that was used before this PR. if a model is defined in the config it changes the model to that, but if not, it stays as the default value
|
And AppConfig is just a type, not a class. We have to see in what way we copy that from Python, there it's a class but TS gives us different options. But that doesn't have to be done in this PR. |
|
AppConfig doesn't require state, so personally I don't think a class would be useful. |
|
Closing this pull request. We will address this issue in a different way. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just a note -- this change requires that model is not a static property of the EmbedChain class, but rather a field of an instance. As a result, the functions getOpenAiAnswer and getAnswerFromLLM are no longer static, but methods on an instance.