Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taps): Check replication method instead of key to determine if a SQL stream is sorted #2418

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented May 8, 2024

Copy link

codspeed-hq bot commented May 8, 2024

CodSpeed Performance Report

Merging #2418 will not alter performance

Comparing 2078/edgarrmondragon/fix/check-replication-method (b702fe8) with main (2874a15)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.18%. Comparing base (2874a15) to head (b702fe8).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2418      +/-   ##
==========================================
- Coverage   89.22%   89.18%   -0.05%     
==========================================
  Files          54       54              
  Lines        4790     4790              
  Branches      937      937              
==========================================
- Hits         4274     4272       -2     
- Misses        359      361       +2     
  Partials      157      157              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the 2078/edgarrmondragon/fix/check-replication-method branch from ace1d61 to d6c4b77 Compare May 15, 2024 20:40
@edgarrmondragon edgarrmondragon force-pushed the 2078/edgarrmondragon/fix/check-replication-method branch 2 times, most recently from fc7aa81 to 1223647 Compare May 27, 2024 22:11
@edgarrmondragon edgarrmondragon force-pushed the 2078/edgarrmondragon/fix/check-replication-method branch from 1223647 to b702fe8 Compare July 2, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant