-
-
Notifications
You must be signed in to change notification settings - Fork 34
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Since [1: 1ebac69] Emacs 26.1 effectively wasn't supported anymore and [2: fa83e81] made that formal, but we should support that release at least a while longer, which do by using the Compat package. 1: 2023-07-18 1ebac69 package-recipe-validate-all: Report progress 2: 2023-12-24 fa83e81 Fix CI build by requiring a newer Emacs
- Loading branch information
Showing
4 changed files
with
8 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,6 +27,7 @@ | |
|
||
;;; Code: | ||
|
||
(require 'compat nil t) | ||
(require 'eieio) | ||
(require 'subr-x) | ||
(require 'url-parse) | ||
|
414b328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@purcell I've restored support for Emacs 26.
414b328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice!
414b328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that some build machinery elsewhere (e.g. the stuff in
nixpkgs
that produces Nix packages from MELPA packages) assumes thatpackage-build
itself has no further dependencies. That code just grabs thepackage-build
repo from github, so it should still work thanks to thenoerror
arg you're passing torequire
.414b328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's why I've added non-nil noerror. Well, to not complicate things on Melpa's own server really. π
414b328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it was good thinking! Also, much more important note: Happy New Year! Hope 2024 and beyond are good for you. π€π€
414b328
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy new year to you too! π₯³