Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add melon to bower #227

Closed
nvlbg opened this issue May 18, 2013 · 14 comments
Closed

Add melon to bower #227

nvlbg opened this issue May 18, 2013 · 14 comments
Milestone

Comments

@nvlbg
Copy link
Contributor

nvlbg commented May 18, 2013

I think it would be nice if you register melon to http://bower.io/

obiot pushed a commit that referenced this issue Jul 8, 2013
@obiot
Copy link
Member

obiot commented Jul 8, 2013

seems that someone already registered it on bower, so i'm closing this one ;)

@obiot obiot closed this as completed Jul 8, 2013
@despairblue
Copy link

Only that it doesn't contain any build source. It's main property references "melonJS-0.9.8-min.js" but there is no such file.

@mik01aj
Copy link

mik01aj commented Nov 22, 2013

I made a pull request: #314. This fixes the path, but one still needs to run grunt in the project directory to get the ready-to-use file.

@parasyte parasyte reopened this Nov 22, 2013
@parasyte
Copy link
Collaborator

Reopened this one, because it's apparently not ready-made for bower. I also want to get the version number dynamically loaded from package.json, so that version increments only need to happen in one file.

And ... moving this ticket to milestone 1.0.0, because I have no idea when these concerns can be addressed.

@parasyte
Copy link
Collaborator

Running npm install on 1.0.0-dev branch logs this to the console:

> [email protected] install /Users/parasyte/projects/melonJS
> bower install;grunt

sh: bower: command not found

@despairblue
Copy link

You need bower installed:

[sudo] npm install -g bower

@parasyte
Copy link
Collaborator

My point is that npm install should install bower before it attempts to run it.

On Nov 30, 2013, at 8:03 AM, Danny Arnold [email protected] wrote:

You need bower installed:

[sudo] npm install -g bower


Reply to this email directly or view it on GitHub.

@despairblue
Copy link

Maybe I'm wrong here, but npm install won't install dependencies globally and bower needs to be installed globally or at least the executable must be somewhere in PATH. So why should npm install install bower? It doesn't install grunt-cli either.

Correct me if I'm wrong here.

@parasyte
Copy link
Collaborator

parasyte commented Dec 3, 2013

Ah, point taken and well-received! This is a simple fix, then. We'll just update README.md to add bower to the install instructions.

@obiot
Copy link
Member

obiot commented Dec 3, 2013

to be honest I'm not super familiar with bower neither (i actually never used it), but about this plugin :

https://npmjs.org/package/grunt-bower-install

@mik01aj
Copy link

mik01aj commented Dec 3, 2013

@obiot: this plugin only adds <script> tags to your HTML.

Bower is a package manager for the web. You type bower install melonJS in some other project and get MelonJS installed. And right now it downloads the source from github and places it in bower_components directory. The problem is that it doesn't build the final JS file (so you have to manually run grunt in the melonJS project) and the path was wrong (I corrected the path in my pr).

So basically you don't need bower as a dependence in your project if you don't use it; and bower.json is a file that tells bower how to install this package in some other environment.

@obiot
Copy link
Member

obiot commented Jan 3, 2014

i'm confused about what is the conclusion for this one, do we then just need to add the following line to the install/build instructions :
npm install -g bower

@mik01aj
Copy link

mik01aj commented Jan 3, 2014

I don't think you need it, unless you install some melonJS dependencies using bower.

bower.json, however, is another thing: it is there to allow melonJS being installed in some other web app.

@obiot
Copy link
Member

obiot commented Jan 3, 2014

All right, thank you for the feedback and I'm therefore closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants