fix: set warnings for upstream compiler libs too#1118
Merged
anmonteiro merged 3 commits intomainfrom May 12, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this fixes a bug that was found when trying to update the melange version in the dune test suite
the root cause is that we slimmed down
melange-compiler-libsquite a bit in melange-re/melange-compiler-libs#40 because we're releasing melange versions specific to each compiler version.As part of the above, we stopped tracking the OCaml parser and lexer, which also emit warnings. Therefore, we must set their warnings appropriately, too.