Fix unused-var warning with polyvars without own cases
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchavarri
commented
Nov 21, 2024
ppx/test/ppx_deriving_json_js.t
Outdated
| if Stdlib.( > ) len 0 then | ||
| let tag = Js.Array.unsafe_get array 0 in | ||
| if Stdlib.( = ) (Js.typeof tag) "string" then | ||
| let tag = (Obj.magic tag : string) in |
There was a problem hiding this comment.
Here was the problem: tag is never used below.
|
Let’s land #32 first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The case
type poly = [ one | other ]triggers a:on the js generated code. This PR fixes it.
mainlet tagdefinition inside the polyvar body expr