Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING] Tasks Parity #425

Merged
merged 9 commits into from
Oct 11, 2023
Merged

[BREAKING] Tasks Parity #425

merged 9 commits into from
Oct 11, 2023

Commits on Sep 28, 2023

  1. Improve Type Safety around Tasks

    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    8fe2855 View commit details
    Browse the repository at this point in the history

  2. Add cancel and delete tasks public APIs

    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    1c8756e View commit details
    Browse the repository at this point in the history

  3. Safely Throw Errors in Tests 

    No functionality change, just an improvement to tests to prevent the test runner from crashing (and less complaints from SwiftLint)
    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    cc8bb7d View commit details
    Browse the repository at this point in the history

  4. Add Integration Tests for New APIs

    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    2dd2fce View commit details
    Browse the repository at this point in the history

  5. Use Types instead of Strings for Task Queries

    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    9dce221 View commit details
    Browse the repository at this point in the history

  6. Update Tests after Rebase

    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    aeb6f44 View commit details
    Browse the repository at this point in the history

  7. Improve Resilience of Delete Test 

    Sometimes it would fail stating the task was still there, I believe this was because it hadn't finished deleting. Hopefully it'll now wait.

Passed 50 iterations locally.
    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    41d7976 View commit details
    Browse the repository at this point in the history

  8. Update Code Samples

    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    f10885c View commit details
    Browse the repository at this point in the history

  9. Apply fix for unit test 

    Other solutions include:

- fetching all documents and asserting total count
- deleting all documents before adding again (expect 8)
- create a new index just for this one test
    @Sherlouk
    Sherlouk committed Sep 28, 2023
    Configuration menu
    Copy the full SHA
    4bcee63 View commit details
    Browse the repository at this point in the history