Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to the typo tolerance customization #282

Closed
5 tasks
brunoocasali opened this issue Apr 11, 2022 · 0 comments · Fixed by #411
Closed
5 tasks

Add support to the typo tolerance customization #282

brunoocasali opened this issue Apr 11, 2022 · 0 comments · Fixed by #411
Labels
good first issue Good for newcomers

Comments

@brunoocasali
Copy link
Member

⚠️ This issue is generated, it means the examples and the namings do not necessarily correspond to the language of this repository.
Also, if you are a maintainer, feel free to add any clarification and instruction about this issue.

Related to:

Add a typoTolerance index settings resource to manage customization of the typo tolerance feature at the index level.

  • Expose typoTolerance object on /indexes/:index_uid/settings endpoints.
  • Add GET/POST/DELETE - /indexes/:index_uid/settings/typo-tolerance endpoints.

The typoTolerance object definition is made of the following properties:

  • enabled type (boolean)
  • disableOnAttributes type (array[string])
  • disableOnWords type (array[string])
  • minWordSizeForTypos type (object)
    • oneTypo type (int)
    • twoTypos type (int)

More information about what each field does could be checked in the spec.

Check the other customization methods for reference like: synonyms, searchableAttributes, filterableAttributes.

TODO:

  • Add the new methods to customize typo-tolerance
    • GET /indexes/:index_uid/settings/typo-tolerance
    • POST /indexes/:index_uid/settings/typo-tolerance
    • DELETE /indexes/:index_uid/settings/typo-tolerance
  • Add tests
@brunoocasali brunoocasali added the good first issue Good for newcomers label Apr 11, 2022
@brunoocasali brunoocasali mentioned this issue Aug 5, 2022
Merged
@Sherlouk Sherlouk mentioned this issue Sep 17, 2023
Merged
3 tasks
meili-bors bot added a commit that referenced this issue Sep 27, 2023
@meili-bors @Sherlouk
Merge #411
827adb4 
411: Add typo-tolerance APIs r=curquiza a=Sherlouk

# Pull Request

## Related issue
Fixes #282 

## What does this PR do?
- Adds support for reading, updating, and resetting typo-tolerance preferences

## PR checklist
Please check if your PR fulfills the following requirements:
- [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
- [x] Have you read the contributing guidelines?
- [x] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!


Co-authored-by: James Sherlock <[email protected]>
@meili-bors meili-bors bot closed this as completed in 33d66ff Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add typo-tolerance APIs Sherlouk/meilisearch-swift
2 participants
@brunoocasali @curquiza