Skip to content

Conversation

meili-bot
Copy link
Contributor

This PR is auto-generated.

Update the code-samples.meilisearch.yml according to the integration-guides issue for more information and the complete description about what should be done here check that issue.
This is the central issue about the Meilisearch release v1.2 in the integrations.

@meili-bot meili-bot added documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs labels May 30, 2023
@bidoubiwa bidoubiwa force-pushed the meili-bot/v1-2-code-samples branch from 338e959 to 4902391 Compare May 31, 2023 10:14
@bidoubiwa bidoubiwa requested a review from alallema May 31, 2023 10:14
@bidoubiwa bidoubiwa marked this pull request as ready for review May 31, 2023 10:14
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well Done 🎉
LGTM!
However, personally, I have put both possibilities so that the user has access to different possibilities:

[["genres = horror", "genres = comedy"]]
// OR
"genres = horror OR genres = comedy"

Copy link
Contributor

@bidoubiwa bidoubiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@meili-bors
Copy link
Contributor

meili-bors bot commented Jun 5, 2023

@meili-bors meili-bors bot merged commit d63bec5 into main Jun 5, 2023
@meili-bors meili-bors bot deleted the meili-bot/v1-2-code-samples branch June 5, 2023 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants