Rename Document trait to IndexConfig and extend with function to retrieve index
#445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
suggested changes
Mar 20, 2023
amaihoefner
force-pushed
the
feat/extend_document_trait
branch
from
7271fa4 to
44cc1c1
Compare
bidoubiwa
suggested changes
Mar 21, 2023
|
Only thing missing is updating the title and the body of the PR. After that it can be released :) |
amaihoefner
changed the title
Document trait to IndexConfig and extend with function to retrieve index
bidoubiwa
added
the
breaking-change
|
bors merge |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Apr 3, 2023
456: Update version for the next release (v0.23.0) r=bidoubiwa a=meili-bot This version makes this package compatible with Meilisearch v1.1 🎉 Check out the changelog of [Meilisearch v1.1](https://github.com/meilisearch/meilisearch/releases/tag/v1.1.0) for more information on the changes. ## 🚀 Enhancements * Add the `multi_search` method on `Client` #454 ##⚠️ Breaking changes * Rename `Document` trait to `IndexConfig` and extend with function to retrieve index (#445) `@amaihoefner` * Add facetstats in the searchResults #443 * Add a new `csv_delimiter` parameter on `index.add_or_replace_unchecked_payload` and `index. add_or_update_unchecked_payload` #455 Thanks again to `@amaihoefner,` and `@shimatar0!` 🎉 Co-authored-by: meili-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Related issue
Fixes #444
What does this PR do?
Documenttrait toIndexConfigIndexConfig::INDEX_STRto store name of the indexIndexConfig::indexfunction to provide easier and safer access to indexPR checklist
Please check if your PR fulfills the following requirements: