Skip to content

Conversation

bidoubiwa
Copy link
Contributor

Breaking change

  • The error field is always present in any kind of Tasks (SuccededTask, etc..), but its value can be Null

@bidoubiwa bidoubiwa added the breaking-change The related changes are breaking for the users label Nov 16, 2022
@bidoubiwa bidoubiwa requested a review from alallema November 16, 2022 17:58
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but but Clippy seems to say that something is wrong 😅

@bidoubiwa bidoubiwa merged commit 48cb827 into bump-meilisearch-v0.30.0 Nov 17, 2022
@bidoubiwa bidoubiwa deleted the bump-meilisearch-v0.30.0-add_error_field_in_task_as_always_present branch November 17, 2022 12:18
bors bot added a commit that referenced this pull request Nov 28, 2022
399: Update version for the next release (v0.21.0) r=bidoubiwa a=bidoubiwa

This version makes this package compatible with Meilisearch v0.30.0 🎉
Check out the changelog of [Meilisearch v0.30.0](https://github.com/meilisearch/meilisearch/releases/tag/v0.30.0) for more information on the changes.

## 🚀 Enhancements

- New `pagination` strategy with the search parameters`page` and `hitsPerPage` #374
- New bulder methods on `get_tasks`: `with_uids`, `with_before_enqueued_at`, ... see #375
- New `client.cancel_tasks` method that lets you cancel `enqueued` and `processing` tasks #377 
- New `client.delete_tasks` method that lets you delete tasks #381 
- New `client.swap_indexes` method that lets you swap two indexes #382

## ⚠️ Breaking change

- builder functions on `TasksQuery` name changes: #375
   - `with_status` -> `with_statuses`
   - `with_index_uid` -> `with_index_uids`
   - `with_type` -> `with_types`
- Task detail `receivedDocumentIds` renamed to `providedIds` #393
- Error field in `Task` is now always present and has a `None` value when there are no errors #390
- Add and rename some error codes: #384 

Co-authored-by: Charlotte Vermandel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change The related changes are breaking for the users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants