Remove Arc on api_key and host in Client structure #338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
the
breaking-change
bidoubiwa
changed the title
|
Hey @Jasperav there seems to be a clippy error. Could you fix it? |
|
@bidoubiwa Welp, forgot to removed the import. I think the CI now auto kicks-off when I commit something, so this won't happen again (I keep an eye open if an error occurs). I see that you labeled this as a breaking change, I doubt a client ever cloned the |
|
@Jasperav yes you're probably right. I just don't want to take any risks |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It just removed an unnecessary
Arc