Change one liners into multiple line commands #329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidoubiwa
added
enhancement
|
Hey @sokratisvas My bad, I forgot to specify that I had to first merge this PR: #297 as there are a LOT of changes on the code-samples. I'll update the issue with this specification, I wasn't expecting someone to contribute before I merged it! If you'd like to work anyways could you rebase this PR on this branch #297? |
|
The changes are pushed to main, you can pull are adapt your changes. If you prefer not you can close this PR. |
|
Hi, I messed up while trying to sync my fork, so I created a new pull request in order to update my changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
What does this PR do?
Fixes #327
PR checklist
Please check if your PR fulfills the following requirements:
Thank you so much for contributing to Meilisearch!