Skip to content

Fix wasm failing build due to getrandom in uuid library #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 30, 2022
Merged

Fix wasm failing build due to getrandom in uuid library #324

merged 2 commits into from
Aug 30, 2022

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Aug 29, 2022 •
edited
Loading

Fixes the wasm fail that was caused by

  • the uuid library using the get_random dependency
  • The Request library of wasm that was not up to date

@bidoubiwa bidoubiwa marked this pull request as draft August 29, 2022 16:30
@brunoocasali
Copy link
Member

Do you think it is worth keeping the UUID v4 client validation?

@bidoubiwa
Copy link
Contributor Author

Well since wasm is used front end anyways and we don't want to allow users to create token on the front end, it has the benefit of removing this method from the wasm build

@bidoubiwa bidoubiwa marked this pull request as ready for review August 30, 2022 13:20
@bidoubiwa bidoubiwa merged commit e808789 into bump-meilisearch-v0.28.0 Aug 30, 2022
@bidoubiwa bidoubiwa deleted the fix_wasm_build branch August 30, 2022 13:21
@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bidoubiwa @brunoocasali