Skip to content

Update dumps for v0.28.0 #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 78 commits into from
Aug 29, 2022
Merged

Update dumps for v0.28.0 #319

merged 78 commits into from
Aug 29, 2022

Conversation

bidoubiwa
Copy link
Contributor

Related to issue: meilisearch/meilisearch#2371

All the changes:

  • Remove code sample get_dump_status_1
  • Remove method get dump status.
  • A dump creation now responds with a task object from type dumpCreation.
  • The error dump_already_processing don't need to be handled.

Breaking changes

  • Method get_dump_status does not exists on Dumps anymore
  • create_dump now returns an TaskInfo

Usage

let task_info: TaskInfo = client.create_dump().await.unwrap();

assert!(matches!(
  task_info,
     TaskInfo {
          update_type: TaskType::DumpCreation { .. },
           ..
       }
   ));

bidoubiwa added 30 commits August 3, 2022 14:28
@bidoubiwa
Update task api v0.28.0
a37ffd3
@bidoubiwa
Update tests to be relevant with the structures where they are ran
b9ffd60
@bidoubiwa
Update types in code-samples
c527312
@bidoubiwa
Remove clearAll task type
17d6c19
@bidoubiwa
Add index_uid as an optional in the Tasks
ff0d350
@bidoubiwa
Add comments on best builder implementation
9241a7b
@bidoubiwa
Add execute function on get_tasks
eb38d18
@bidoubiwa
Update code samples
d37be56
@bidoubiwa
Remove out of context comment
61be5a5
@bidoubiwa
Merge
7aa409b
@bidoubiwa
Fix tests
c968df3
@bidoubiwa
Fix pagination tests
c21b18f
@bidoubiwa
Update HTTP methods for v0.28.0
012f939
@bidoubiwa
Fix clippy
0cb9e93
@bidoubiwa
Merge branch 'update_task_api_for_v0.28.0' of github.com:meilisearch/…
a485ba5 
…meilisearch-rust into update_http_methods_for_v0.28.0
@bidoubiwa
Remove comment of task tests since the tests are now sucesful
f86bff4
@bidoubiwa
Fix doc tests
734fd13
@bidoubiwa
Merge branch 'update_task_api_for_v0.28.0' of github.com:meilisearch/…
e5821c4 
…meilisearch-rust into update_http_methods_for_v0.28.0
@bidoubiwa
Update keys for v0.28.0
11bfb7e
@bidoubiwa
Fix get tasks inside index structure
6b70f5a
@bidoubiwa
Make description and name optional in keys
604e08d
@bidoubiwa
Fix none doc tests with new get_tasks api
67637c2
@bidoubiwa
Add from and limit in tasks params
c2dcd92
@bidoubiwa
Add warning on failing test
efff813
@bidoubiwa
Merge branch 'update_task_api_for_v0.28.0' of https://github.com/meil…
f0020b6 
…isearch/meilisearch-rust into update_http_methods_for_v0.28.0
@bidoubiwa
Merge
e0762b1
@bidoubiwa
Update keys design
c1796a3
@bidoubiwa
Update task API
abc0f7b
@bidoubiwa
Remove useless comment
eaef1ea
@bidoubiwa
Merge branch 'update_task_api_for_v0.28.0' of https://github.com/meil…
bdf4f13 
…isearch/meilisearch-rust into update_http_methods_for_v0.28.0
bidoubiwa added 19 commits August 24, 2022 12:45
@bidoubiwa
remove exhaustive facets count
7c8d8a0
@bidoubiwa
Change matches to show_matches_position
3d1682d
@bidoubiwa
Change matches_info to matches_position
de69f44
@bidoubiwa
Update search api for v0.28.1
f7d9862
@bidoubiwa
Improve comment syntax
c6c2833
@bidoubiwa
Hide client creation in search query builder doc test
49ec3c5
@bidoubiwa
Add DocumentsQuery and DocumentsResults
c3f3939
@bidoubiwa
Resolve merge conflicts
33629b9
@bidoubiwa
Rollback wrong merging
2062dce
@bidoubiwa
Merge branch 'update_search_for_v0.28.0' of github.com:meilisearch/me…
25fb8b5 
…ilisearch-rust into update_documents_for_v0.28.0
@bidoubiwa
Fix failing key tests
8c1bcba
@bidoubiwa
Merge branch 'update_search_for_v0.28.0' of github.com:meilisearch/me…
405e0f4 
…ilisearch-rust into update_documents_for_v0.28.0
@bidoubiwa
Merge branch 'bump-meilisearch-v0.28.0' of github.com:meilisearch/mei…
1499f7e 
…lisearch-rust into update_documents_for_v0.28.0
@bidoubiwa
Add documentation
4754825
@bidoubiwa
Fix execute doc test
a262309
@bidoubiwa
Fix clippy tests
be22268
@bidoubiwa
Update tenant token api for v0.28.1
d60ac80
@bidoubiwa
Fix clippy warning
c1affa9
@bidoubiwa
Update dump api for v0.28.0
d6dce72
@bidoubiwa bidoubiwa changed the base branch from main to update_tokens_for_v0.28.0 August 25, 2022 15:42
@bidoubiwa bidoubiwa requested review from alallema and irevoire August 25, 2022 15:43
@bidoubiwa bidoubiwa marked this pull request as ready for review August 25, 2022 15:43
@bidoubiwa bidoubiwa added the breaking-change The related changes are breaking for the users label Aug 25, 2022
alallema
alallema approved these changes Aug 25, 2022
View reviewed changes
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Base automatically changed from update_tokens_for_v0.28.0 to bump-meilisearch-v0.28.0 August 29, 2022 14:46
@bidoubiwa bidoubiwa merged commit 6c11842 into bump-meilisearch-v0.28.0 Aug 29, 2022
@bidoubiwa bidoubiwa deleted the update_dumps_for_v0.28.0 branch August 29, 2022 14:48
@bidoubiwa bidoubiwa mentioned this pull request Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@irevoire irevoire Awaiting requested review from irevoire

1 more reviewer

@alallema alallema alallema approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

breaking-change The related changes are breaking for the users

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bidoubiwa @alallema