Skip to content

Conversation

@bidoubiwa
Copy link
Contributor

@bidoubiwa bidoubiwa commented Aug 3, 2022

Changes related to the HTTP verbs

Related to:

To be more compliant with the RESTful good practices we must change the following verbs:

  • PATCH /indexes/{indexUid} instead of PUT
  • PATCH /indexes/{indexUid}/settings instead of POST
  • PATCH /indexes/{indexUid}/settings/typo-tolerance instead of POST
  • PUT /indexes/{indexUid}/settings/displayed-attributes instead of POST
  • PUT /indexes/{indexUid}/settings/distinct-attribute instead of POST
  • PUT /indexes/{indexUid}/settings/filterable-attributes instead of POST
  • PUT /indexes/{indexUid}/settings/ranking-rules instead of POST
  • PUT /indexes/{indexUid}/settings/searchable-attributes instead of POST
  • PUT /indexes/{indexUid}/settings/sortable-attributes instead of POST
  • PUT /indexes/{indexUid}/settings/stop-words instead of POST
  • PUT /indexes/{indexUid}/settings/synonyms instead of POST

@bidoubiwa bidoubiwa added the skip-changelog The PR will not appear in the release changelogs label Aug 3, 2022
@bidoubiwa bidoubiwa marked this pull request as ready for review August 3, 2022 14:36
@bidoubiwa bidoubiwa requested review from alallema, brunoocasali and irevoire and removed request for brunoocasali August 3, 2022 15:01
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

Base automatically changed from update_task_api_for_v0.28.0 to bump-meilisearch-v0.28.0 August 22, 2022 11:35
@bidoubiwa bidoubiwa requested a review from alallema August 22, 2022 11:37
@bidoubiwa bidoubiwa merged commit 99f9e39 into bump-meilisearch-v0.28.0 Aug 22, 2022
@bidoubiwa bidoubiwa deleted the update_http_methods_for_v0.28.0 branch August 22, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog The PR will not appear in the release changelogs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants