Refactorise the settings #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kerollmops
requested changes
Feb 10, 2022
get rid of the IntoVecString trait Apply review comments Co-authored-by: Clément Renault <[email protected]>
Kerollmops
approved these changes
Feb 10, 2022
|
Is it breaking for the user or is it only internal refactoring? |
|
It's only internal and should be more flexible for the user. |
|
bors merge |
|
Build succeeded: |
bors bot
added a commit
that referenced
this pull request
Feb 16, 2022
243: Update version for the next release (v0.15.0) r=brunoocasali a=brunoocasali ##⚠️ Breaking changes * Refactorise the errors, now `error_code` and `error_type` has types instead of `string` (#234) `@irevoire` * Put type on timestamp and duration (#237) `@irevoire` * The `time` crate will be needed if you need to manipulate API keys (check for more info #226, #237 (comment), and meilisearch/integration-guides#121 (comment)). ## 🚀 Enhancements * Refactorise the settings (#235) `@irevoire` Thanks again to `@irevoire!` 🎉 Co-authored-by: Bruno Casali <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the two types
Settings.It also gets rids of the
IntoVecStringin favor of a simplerIntoIterator<Item = AsRef<str>>, which is more versatile and common in rust.