Skip to content

Conversation

irevoire
Copy link
Contributor

@irevoire irevoire commented Feb 9, 2022

Implements the API key:

  • The get_key, delete_key, update_key and create_key methods have been implemented with unit and doc test
  • The authenticate error code has been renamed into auth
  • 6 new errors have been added: MissingParameter, InvalidApiKeyDescription, InvalidApiKeyActions, InvalidApiKeyIndexes, InvalidApiKeyExpiresAt, ApiKeyNotFound
  • The Key type has been moved to a different module
  • A KeyBuilder type has been added to eases the creation of keys
  • An Action enum has been created to represents all the possible action

@irevoire irevoire marked this pull request as ready for review February 9, 2022 15:30
@irevoire irevoire force-pushed the api-key branch 2 times, most recently from b1e735a to e5fff22 Compare February 9, 2022 15:34
@curquiza curquiza added the breaking-change The related changes are breaking for the users label Feb 9, 2022
Copy link
Contributor

@alallema alallema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR @irevoire 🔥
LGTM!

@irevoire irevoire force-pushed the api-key branch 2 times, most recently from 0174e98 to a2151e5 Compare February 9, 2022 16:44
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you Tamo!

fix the wasm build

Apply review comments

Co-authored-by: Clément Renault <[email protected]>

fix wasm
Copy link
Member

@Kerollmops Kerollmops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, merging!
bors merge

@bors
Copy link
Contributor

bors bot commented Feb 9, 2022

🔒 Permission denied

Existing reviewers: click here to make Kerollmops a reviewer

@irevoire
Copy link
Contributor Author

irevoire commented Feb 9, 2022

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 9, 2022

🔒 Permission denied

Existing reviewers: click here to make irevoire a reviewer

@bidoubiwa
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 9, 2022

🔒 Permission denied

Existing reviewers: click here to make bidoubiwa a reviewer

@irevoire
Copy link
Contributor Author

irevoire commented Feb 9, 2022

bad bors

@brunoocasali
Copy link
Member

bors merge

@bors
Copy link
Contributor

bors bot commented Feb 9, 2022

Build succeeded:

@bors bors bot merged commit 6685d0c into meilisearch:bump-meilisearch-v0.25.0 Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change The related changes are breaking for the users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants