Skip to content

Conversation

alallema
Copy link
Contributor

@alallema alallema commented Nov 22, 2021

Pull Request

Change due to implicate index creation

@alallema alallema force-pushed the implicit_index_creation branch 5 times, most recently from a82e96d to a56e8e4 Compare November 25, 2021 17:39
@alallema alallema force-pushed the implicit_index_creation branch from a56e8e4 to 6e4f749 Compare November 29, 2021 09:08
@alallema alallema requested a review from curquiza December 6, 2021 10:41
@curquiza curquiza added the breaking-change The related changes are breaking for the users label Dec 7, 2021
Copy link
Member

@curquiza curquiza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @alallema! thank you so much

bors merge

bors bot added a commit that referenced this pull request Dec 7, 2021
211: Changes due to the implicit index creation r=curquiza a=alallema

# Pull Request

## Change due to implicate index creation
- [x] Update code_sample
- [x] Modify the README
- [x] Follow meilisearch/integration-guides#48
- [x] Modify tests

Co-authored-by: alallema <[email protected]>
@curquiza
Copy link
Member

curquiza commented Dec 7, 2021

bors merge

@curquiza
Copy link
Member

curquiza commented Dec 7, 2021

bors merge-

@curquiza
Copy link
Member

curquiza commented Dec 7, 2021

Merging by hand because bors seems to be broken...

@curquiza curquiza merged commit 91d0d65 into main Dec 7, 2021
@curquiza curquiza deleted the implicit_index_creation branch December 7, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-change The related changes are breaking for the users

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants