Skip to content

Conversation

@ellnix
Copy link
Contributor

@ellnix ellnix commented Jan 25, 2025

Pull Request

This contains preliminary work on #596 to address the lack of anything more than surface-level documentation on this gem.

Related issue

Fixes #596

How to view documentation

  1. gem install yardoc
  2. yardoc doc
  3. yardoc server
  4. Visit localhost:8808

With live updates:
requires entr

  • In terminal 1: ls lib/**/*.rb | entr -c yardoc doc
  • In terminal 2: yard server -r

Steps

  • Wait for input on yardoc documentation #596
  • Write documentation for other files
  • Add documentation check to Github actions
  • Publish documentation

@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6ffc322) to head (02418e2).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #602   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          804       804           
=========================================
  Hits           804       804           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ellnix ellnix changed the title Add yardoc documentation Add yardoc documentation to client.rb Mar 31, 2025
@ellnix ellnix changed the title Add yardoc documentation to client.rb Add yardoc documentation to client.rb Mar 31, 2025
@ellnix ellnix requested a review from brunoocasali March 31, 2025 19:33
@ellnix ellnix marked this pull request as ready for review March 31, 2025 19:33
brunoocasali
brunoocasali previously approved these changes Apr 1, 2025
@ellnix
Copy link
Contributor Author

ellnix commented Apr 2, 2025

Had to deal with rubocop again @brunoocasali

Copy link
Member

@brunoocasali brunoocasali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors merge

@brunoocasali brunoocasali added the enhancement New feature or request label Apr 4, 2025
@meili-bors
Copy link
Contributor

meili-bors bot commented Apr 4, 2025

Build succeeded:

@meili-bors meili-bors bot merged commit dd4ec5f into meilisearch:main Apr 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

yardoc documentation

2 participants